[Merged by Bors] - Fix for bevy CI on main - clippy safety comments on trait. #5665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhellermann
approved these changes
Aug 13, 2022
tim-blackbird
approved these changes
Aug 13, 2022
bors bot
pushed a commit
that referenced
this pull request
Aug 13, 2022
# Objective Make CI pass on bevy main. Update to rust-1.63, updated clippy to 1.63 which introduced the following enhancements: - [undocumented_unsafe_blocks](https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks): Now also lints on unsafe trait implementations This caught two incorrectly written ( but existing) safety comments for unsafe traits. ## Solution Fix the comment to use `SAFETY:`
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
maccesch
pushed a commit
to Synphonyte/bevy
that referenced
this pull request
Sep 28, 2022
…e#5665) # Objective Make CI pass on bevy main. Update to rust-1.63, updated clippy to 1.63 which introduced the following enhancements: - [undocumented_unsafe_blocks](https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks): Now also lints on unsafe trait implementations This caught two incorrectly written ( but existing) safety comments for unsafe traits. ## Solution Fix the comment to use `SAFETY:`
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…e#5665) # Objective Make CI pass on bevy main. Update to rust-1.63, updated clippy to 1.63 which introduced the following enhancements: - [undocumented_unsafe_blocks](https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks): Now also lints on unsafe trait implementations This caught two incorrectly written ( but existing) safety comments for unsafe traits. ## Solution Fix the comment to use `SAFETY:`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…e#5665) # Objective Make CI pass on bevy main. Update to rust-1.63, updated clippy to 1.63 which introduced the following enhancements: - [undocumented_unsafe_blocks](https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks): Now also lints on unsafe trait implementations This caught two incorrectly written ( but existing) safety comments for unsafe traits. ## Solution Fix the comment to use `SAFETY:`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Make CI pass on bevy main.
Update to rust-1.63, updated clippy to 1.63 which introduced the following enhancements:
This caught two incorrectly written ( but existing) safety comments for unsafe traits.
Solution
Fix the comment to use
SAFETY: